Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close the ncselect dropdown when clicked somewhere else #9806

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Jul 5, 2024

noticed while testing #9801
when i select a 'to' and i want to add a 'cc' the dropdown doesnt close

Screenshot from 2024-07-05 14-34-31

Signed-off-by: greta <gretadoci@gmail.com>
@GretaD GretaD requested a review from st3iny July 5, 2024 12:36
@GretaD GretaD self-assigned this Jul 5, 2024
@ChristophWurst ChristophWurst requested review from GVodyanov and removed request for ChristophWurst July 8, 2024 18:11
Copy link
Contributor

@GVodyanov GVodyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@ChristophWurst ChristophWurst merged commit d2fa4e3 into main Jul 15, 2024
28 checks passed
@ChristophWurst ChristophWurst deleted the fix/ncselect-active-state branch July 15, 2024 10:10
@ChristophWurst
Copy link
Member

/backport to stable3.7

Copy link

backportbot bot commented Jul 15, 2024

The backport to stable3.7 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable3.7
git pull origin stable3.7

# Create the new backport branch
git checkout -b backport/9806/stable3.7

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d6daaef6

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/9806/stable3.7

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants