Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: background-color of outbox-button #9802

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix: background-color of outbox-button #9802

merged 1 commit into from
Jul 9, 2024

Conversation

PeterJGDe
Copy link
Member

@PeterJGDe PeterJGDe commented Jul 5, 2024 •
edited
Loading

fixes: #9707

Before:
336733757-46ea6125-6761-49a5-bfa9-3a4d8742dcda

After:
Bildschirmfoto vom 2024-07-05 11-27-36
Bildschirmfoto vom 2024-07-05 11-27-12

@PeterJGDe PeterJGDe requested a review from GretaD July 5, 2024 08:28
@welcome Welcome
Copy link

welcome bot commented Jul 5, 2024

Thanks for opening your first pull request in this repository! ✌️

@PeterJGDe PeterJGDe marked this pull request as draft July 5, 2024 08:40
@PeterJGDe PeterJGDe self-assigned this Jul 5, 2024
@PeterJGDe PeterJGDe marked this pull request as ready for review July 5, 2024 09:21
@PeterJGDe
Copy link
Member Author

PeterJGDe commented Jul 5, 2024 •
edited
Loading

@marcoambrosini @jancborchardt @nimishavijay I changed the space of the breaking line and the Outbox button. What do you think about it?

GretaD
GretaD approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code wise is good, and i like the space between the breaking line and the button :)

@PeterJGDe
fix: background-color of outbox-button
ca8310b 
Signed-off-by: Peter-J. G. <peter.germelmann@gmail.com>
@PeterJGDe PeterJGDe force-pushed the fix/9707/outbox-active-background-color branch from 5bce35a to ca8310b Compare July 8, 2024 09:57
@PeterJGDe PeterJGDe merged commit b546071 into main Jul 9, 2024
28 checks passed
@PeterJGDe PeterJGDe deleted the fix/9707/outbox-active-background-color branch July 9, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GretaD GretaD GretaD approved these changes

@nimishavijay nimishavijay nimishavijay approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

Assignees

@PeterJGDe PeterJGDe

Labels
3. to review bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outbox has the wrong font colour when active
3 participants
@PeterJGDe @GretaD @nimishavijay