fix(integration): Honor sharing to group members restriction #9788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
st3iny
approved these changes
Aug 13, 2024
st3iny
deleted the
fix/integration/nextcloud-sharing-groups-restriction
branch
|
/backport to stable3.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8595 with a minimal approach. The server settings are reeeeaaally complex. You can allow sharing, but restrict to groups, but allow some groups on top. This is hard to replicate in the Mail app. I suggest we simply turn off the group integration when advanced sharing settings are on.
How to test
main: you can pick any group
here: you can not pick any groups