Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tidy up search bar #9770

Closed
wants to merge 1 commit into from
Closed

feat: tidy up search bar #9770

wants to merge 1 commit into from

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Jun 24, 2024

fixes #9755

Screenshot from 2024-06-24 15-25-59
Screenshot from 2024-06-24 15-25-54

@GretaD GretaD self-assigned this Jun 24, 2024
@GretaD
Copy link
Contributor Author

GretaD commented Jun 24, 2024

The close button shows only when the filter is active. So having the filter icon in the end make more sense as that icon is there all the time.

marcoambrosini
marcoambrosini approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok design wise but didn't test

@GretaD
enhanc: tidy up search bar
aa2ad42 
Signed-off-by: greta <gretadoci@gmail.com>
@GretaD GretaD mentioned this pull request Jul 23, 2024
Merged
@GretaD
Copy link
Contributor Author

GretaD commented Jul 23, 2024

closing on behalf of #9901

@GretaD GretaD closed this Jul 23, 2024
@ChristophWurst ChristophWurst deleted the fix/search-field branch July 30, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

Assignees

@GretaD GretaD

Labels
3. to review enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tidy up search bar
2 participants
@GretaD @marcoambrosini