feat: increaze the min and max width for horizontal view #9700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i added random numbers, @jancborchardt please test it and let me know how much the % should be |
ShGKme
reviewed
Jun 18, 2024
src/components/MailboxThread.vue
Outdated
Comment on lines
155
to
156
| horizontalListMinWidth() { | ||
| return this.layoutMode === 'horizontal-split' ? 60 : this.defaultListMinWidth |
There was a problem hiding this comment.
defaultListMinWidth is actually a vertical-split value. IMO, it can be a constant number instead of "default".
|
One minor issue, |
Signed-off-by: greta <gretadoci@gmail.com>
GretaD
force-pushed
the
feat/increaze-horizontal-max-width
branch
from
87d47c2
to
cef3c44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9573
i added random numbers @jancborchardt please test it and let me know how much the % should be