-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] #9298 : Add several e-mail addresses into address fields at once #9347
base: main
Are you sure you want to change the base?
[Feature] #9298 : Add several e-mail addresses into address fields at once #9347
Conversation
@ChristophWurst I pushed this last commit into this PR for review, and I'm not sure if it applies to this task or not:
Hint this is relevant to this task, if yes, I will cover these cases with code. If there are more, I will be ready to solve them :) |
58dd9b5
to
3887fc8
Compare
@ChristophWurst any updates here? Thanks :) |
This is a bit of a gamble with the regex. Can you make sure that selecting people with titles doesn't split single values? E.g. if "Jane Doe, MSc jane@doe.tld" is entered, it should stay "Jane Doe, MSc jane@doe.tld", not become "Jane Doe" and ", MSc jane@doe.tld" |
3887fc8
to
f9da4ce
Compare
8ca309b
to
4adceef
Compare
@ChristophWurst , yes done, I fixed some cases and tested, could you please see the new changes and write me feedback, what do you think about this? Maybe I need to change something in my solution? P.S. Maybe need to move the regex to another space somewhere, so that it can be accessed in any other classes in the project? |
…o address fields at once Signed-off-by: Andrii Rublov <airublev@outlook.com>
Signed-off-by: Andrii Rublov <airublev@outlook.com>
Signed-off-by: Andrii Rublov <airublev@outlook.com>
Signed-off-by: Andrii Rublov <airublev@outlook.com>
… Last commit for change PR to review Signed-off-by: Andrii Rublov <airublev@outlook.com>
6e9e6a0
to
d1c7b42
Compare
@ChristophWurst I was doing research on this a couple days ago and tried your examples based on thunderbird, gmail and roundcube. So created a more flexible solution based on these apps and my research, so if I need to further improve or change the logic in my solution I will be happy to work on this further :) Just FYI:How works Thunderbird:
How works Web Gmail
All of these invalid Look: rfc822 standard |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Details:
Case 1:
string = 'test@test.com, Jane Doe, MSc jane@doe.tld'
Result:
newRecipients:
Case 2:
string = 'ian eiloart iane@example.ac.uk>;shuf6@example.ac.uk,, test+user@company.c, "ian,eiloart"<ian@example.ac.uk>, <@example.com:foo@example.ac.uk>, foo@#,ian@-example.com, ian@one@two;asdas< test@test.com> test@test.com, Newasd Na@,me >; testaaaa@aasd.com'
Result:
newRecipients: