feat: delete tags #8870
Merged
feat: delete tags #8870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamza221
added
2. developing
enhancement
feature:tags
skill:backend
hamza221
requested review from
kesselb,
ChristophWurst and
GretaD
and removed request for
kesselb and
ChristophWurst
kesselb
reviewed
Sep 27, 2023
hamza221
force-pushed
the
enh/delete-tags
branch
from
d56656f
to
90966b4
Compare
kesselb
reviewed
Sep 29, 2023
kesselb
reviewed
Oct 17, 2023
hamza221
force-pushed
the
enh/delete-tags
branch
from
824d280
to
ad66a0a
Compare
st3iny
reviewed
Oct 27, 2023
There was a problem hiding this comment.
Tested and works.
If a tag is deleted that is assigned to the currently opened email, its tag list (below the header) won't be updated immediately. Changing to another email and back again updates the list accordingly.
I don't consider this a hard blocker.
PS: Eslint and psalm are not happy yet.
/home/runner/work/mail/mail/src/components/TagItem.vue
Error: 94:15 error Custom event name 'deleteTag' must be kebab-case vue/custom-event-name-casing
076e0fe
to
1a95848
Compare
Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
hamza221
force-pushed
the
enh/delete-tags
branch
from
a796a2b
to
50f0772
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5146