Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework routing, data structures and naming ambiguities #3439

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Rework routing, data structures and naming ambiguities #3439

merged 1 commit into from
Aug 25, 2020

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Aug 11, 2020 •
edited
Loading

This changes a lot of things

  • Mailboxes are identified by their database ID (as opposed to account ID and name)
  • Messages are identified by their database ID (as opposed to account ID, mailbox name and message UID)
  • Routes are simplified and use the browser history API (as opposed to client-only anchor routes)
  • The Vuex store got a lot simpler, because the normalization is obsolete due to the naturally unique IDs
  • Naming inconsistency of maibox/folder finally resolved -> we call it "mailbox" in the code (as that is the proper name by the standards) and "folder" for the user (because @jancborchardt prefers that)

Required for deep links in #3433 and possibly for threading.

  • (accountId, folderId) to mailbox ID
  • Drafts handling (with db IDs)
  • Sync handling (with db IDs)

@ChristophWurst ChristophWurst added this to the v1.5 milestone Aug 11, 2020
@ChristophWurst ChristophWurst self-assigned this Aug 11, 2020
@ChristophWurst ChristophWurst changed the title Rework the routing Rework routing, data structures and naming ambiguities Aug 13, 2020
@ChristophWurst ChristophWurst mentioned this pull request Aug 19, 2020
Open
@ChristophWurst
Rework the routing
9498eba 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst marked this pull request as ready for review August 25, 2020 08:53
@GretaD GretaD merged commit 98f476b into master Aug 25, 2020
@GretaD GretaD deleted the techdept/routing-rework branch August 25, 2020 09:30
This was referenced Aug 26, 2020
Merged
Merged
Merged
Merged
@ChristophWurst ChristophWurst mentioned this pull request Oct 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GretaD GretaD GretaD approved these changes

@violoncelloCH violoncelloCH Awaiting requested review from violoncelloCH

@rullzer rullzer Awaiting requested review from rullzer

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@Gomez Gomez Awaiting requested review from Gomez

Assignees

@ChristophWurst ChristophWurst

Labels
2. developing 3. to review enhancement technical debt
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristophWurst @GretaD