Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilevel mailbox structure #3147

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Conversation

dehnhardt
Copy link
Collaborator

@dehnhardt dehnhardt commented May 22, 2020

  • (Soft) requires Bump @nextcloud/vue from 1.5.0 to 2.6.0 #3466
  • Logic for addAccount
  • Logic for addMailbox
  • Edge case: removal of a mailbox that has children -> children should be promoted by one level (if IMAP even allow this operation) -> problematic on IMAP level as well, so we're hiding the delete action for mailboxes with children.
  • Detect and persist personal namespace (related to Add a setting for personal namespaces #3272, but fully automated)

Fixes #794

Signed-off-by: Holger Dehnhardt holger@dehnhardt.org
With this pr it is possible to display a folder structure of any depth.
The structure is only created using the getter in the frontend.
Creating new folders within the structure works - but is not tested carefully.
There are some problems with the display.

  • Replacing the folder icons with the arrows does not work properly
    image

  • the navigation area quickly becomes too narrow.
    See comments inside the changes...
    image

To make the goal of this PR clearer, this picture shows how the structure is presented so far:
image

lib/Folder.php Outdated Show resolved Hide resolved
src/store/getters.js Outdated Show resolved Hide resolved
src/store/mutations.js Outdated Show resolved Hide resolved
@jancborchardt

This comment has been minimized.

@dehnhardt

This comment has been minimized.

@dehnhardt

This comment has been minimized.

@dehnhardt

This comment has been minimized.

lib/Folder.php Outdated Show resolved Hide resolved
src/components/NavigationFolder.vue Outdated Show resolved Hide resolved
src/components/NavigationFolder.vue Outdated Show resolved Hide resolved
@ChristophWurst
Copy link
Member

I'm currently focusing on #2125 but I'll look into this soon.

@dehnhardt
Copy link
Collaborator Author

I'm currently focusing on #2125 but I'll look into this soon.

I've seen that. Take your time ;-)

@dehnhardt
Copy link
Collaborator Author

@ChristophWurst: Now that nextcloud-libraries/nextcloud-vue#1140 has come to the mails masterbranch, wouldn't it be wonderful to have this in master as well ;-)
Rebased and squashed.

@ChristophWurst
Copy link
Member

Sure, let's do this :) This requires a few adaptations for #3439 but I can help with that if you like.

lib/Folder.php Outdated Show resolved Hide resolved
@ChristophWurst
Copy link
Member

I took the liberty to just rebase the branch, resolve the conflicts and fix some unused code (leftover from previous rebase possibly).

The patch looks clean, but I'm unsure if your attended changes are still here. Could you please check and give me a quick update? We can always reset to an older state if I accidentally dropped some important changes 🙏

@dehnhardt
Copy link
Collaborator Author

To be honest, I can no longer tell which changes were originally mine and which are yours.
But I checked out and tested the branch on my test system and it seems to work how it should.
I just wonder why the indentation is still so big. Is the current Nextcloud vue version not merged yet?

@ChristophWurst
Copy link
Member

To be honest, I can no longer tell which changes were originally mine and which are yours.
But I checked out and tested the branch on my test system and it seems to work how it should.

No worries. I spent some time on this yesterday and also added some unit tests.

I just wonder why the indentation is still so big. Is the current Nextcloud vue version not merged yet?

It's not, hence the TODO in the PR description.

@ChristophWurst ChristophWurst self-assigned this Aug 28, 2020
Signed-off-by: Holger Dehnhardt <holger@dehnhardt.org>
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants