-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multilevel mailbox structure #3147
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I'm currently focusing on #2125 but I'll look into this soon. |
I've seen that. Take your time ;-) |
@ChristophWurst: Now that nextcloud-libraries/nextcloud-vue#1140 has come to the mails masterbranch, wouldn't it be wonderful to have this in master as well ;-) |
Sure, let's do this :) This requires a few adaptations for #3439 but I can help with that if you like. |
363e29d
to
8506014
Compare
I took the liberty to just rebase the branch, resolve the conflicts and fix some unused code (leftover from previous rebase possibly). The patch looks clean, but I'm unsure if your attended changes are still here. Could you please check and give me a quick update? We can always reset to an older state if I accidentally dropped some important changes 🙏 |
641f69d
to
8c8784e
Compare
To be honest, I can no longer tell which changes were originally mine and which are yours. |
No worries. I spent some time on this yesterday and also added some unit tests.
It's not, hence the TODO in the PR description. |
Signed-off-by: Holger Dehnhardt <holger@dehnhardt.org>
27518ee
to
df94a5e
Compare
c3c6996
to
5603913
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and works
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
5603913
to
9d1365e
Compare
addAccount
addMailbox
Edge case: removal of a mailbox that has children -> children should be promoted by one level (if IMAP even allow this operation)-> problematic on IMAP level as well, so we're hiding the delete action for mailboxes with children.Fixes #794
Signed-off-by: Holger Dehnhardt holger@dehnhardt.org
With this pr it is possible to display a folder structure of any depth.
The structure is only created using the getter in the frontend.
Creating new folders within the structure works - but is not tested carefully.
There are some problems with the display.
Replacing the folder icons with the arrows does not work properly
the navigation area quickly becomes too narrow.
See comments inside the changes...
To make the goal of this PR clearer, this picture shows how the structure is presented so far: