Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore acl ui in sharing tab #2736

Merged
merged 7 commits into from
Jan 11, 2024
Merged

restore acl ui in sharing tab #2736

merged 7 commits into from
Jan 11, 2024

Conversation

icewind1991
Copy link
Member

Fixes #2637

This can probably use some larger rework to make thing modern™ but for now this seems to fix things

@icewind1991 icewind1991 added the 3. to review Items that need to be reviewed label Jan 9, 2024
@juliushaertl
Copy link
Member

More modern approach with the vue rewrite would be a separate entrypoint to register dav properties that is loaded early

https://github.com/nextcloud/files_lock/blob/main/src/init.ts
https://github.com/nextcloud/files_lock/blob/main/lib/Listeners/LoadAdditionalScripts.php#L47

Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works, just CI isn't happy yet

@come-nc
Copy link
Contributor

come-nc commented Jan 9, 2024

Crashes my activity tab 🤷

@come-nc
Copy link
Contributor

come-nc commented Jan 9, 2024

I tried with stable28 branch on all apps, this one for groupfolders, activity tab crashes on opening on a groupfolder:

[Vue warn]: Error in beforeMount hook: "TypeError: client is undefined"

found in

---> <SharingSidebarView> at src/components/SharingSidebarView.vue
       <SharingTab>
         <NcAppSidebarTab>
           <SidebarTab>
             <NcAppSidebarTabs>
               <NcAppSidebar>
                 <Root> vue.runtime.esm.js:4609
TypeError: client is undefined
    propFind client.js:177
    loadAcls SharingSidebarView.vue:93
    beforeMount SharingSidebarView.vue:86
    VueJS 18
    mount files_sharing_tab.js:74
vue.runtime.esm.js:3049
Error loading the activity list ReferenceError: error is not defined
    loadRealActivities https://nextcloud.local/apps-extra/activity/js/ActivityTab-c3b30cc4.mjs:3
ActivityTab-c3b30cc4.mjs:3:1487
[Vue warn]: $attrs is readonly.

found in

---> <SharingSidebarView> at src/components/SharingSidebarView.vue
       <SharingTab>
         <NcAppSidebarTab>
           <SidebarTab>
             <NcAppSidebarTabs>
               <NcAppSidebar>
                 <Root> vue.runtime.esm.js:4609
[Vue warn]: $listeners is readonly.

found in

---> <SharingSidebarView> at src/components/SharingSidebarView.vue
       <SharingTab>
         <NcAppSidebarTab>
           <SidebarTab>
             <NcAppSidebarTabs>
               <NcAppSidebar>
                 <Root> vue.runtime.esm.js:4609

Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
Copy link
Member Author

warning should be fixed with the dependency updates

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against server master (Files + Groupfolders only), works as expected, saw nothing related in the console

Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
Copy link
Member Author

/backport to stable28

@icewind1991 icewind1991 merged commit b677df8 into master Jan 11, 2024
40 checks passed
@icewind1991 icewind1991 deleted the restore-acl-ui branch January 11, 2024 17:00
@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Items that need to be reviewed backport-request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACL permissions are not shown in Files sidebar
4 participants