Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Enable full screen mode for PDF files #60

Merged

Conversation

danxuliu
Copy link
Member

@danxuliu danxuliu commented Mar 9, 2018

Backport of #57

The PDF viewer provides a "Full screen" button when it detects that the
browser supports the full screen mode and that the PDF is inside an
element that can be displayed full screen. Therefore, as the PDF viewer
is shown inside an "iframe" element its "allowfullscreen" attribute must
be set to "true".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@danxuliu danxuliu added this to the Nextcloud 12.0.6 milestone Mar 9, 2018
@MorrisJobke MorrisJobke mentioned this pull request Mar 9, 2018
2 tasks
@MorrisJobke MorrisJobke merged commit 3821dbe into stable12 Mar 9, 2018
@MorrisJobke MorrisJobke deleted the stable12-57-enable-fullscreen-mode-for-pdf-files branch March 9, 2018 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants