Enable full screen mode for PDF files #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PDF viewer provides a "Full screen" button when it detects that the browser supports the full screen mode and that the PDF is inside an element that can be displayed full screen. Therefore, as the PDF viewer is shown inside an "iframe" element its "allowfullscreen" attribute must be set to "true". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
|
@danxuliu Mind to do the backport? So we have this fixed in 13.0.1 as well? |
10 tasks
This was referenced Mar 9, 2018
|
@MorrisJobke Done; as it was straightforward to do it I also backported it to stable12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PDF viewer provides a Full screen button when it detects that the browser supports the full screen mode and that the PDF is inside an element that can be displayed full screen. Therefore, as the PDF viewer is shown inside an
iframeelement itsallowfullscreenattribute must be set totrue.Note that the Full screen button was already shown in Chromium before this pull request (although, unless I am missing something, it should not have been shown); now the button is available too in Firefox. I have not tested other browsers.