Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remote wipe keychain storage (issue #1592) #1646

Merged
merged 2 commits into from
Nov 29, 2019
Merged

Fix remote wipe keychain storage (issue #1592) #1646

merged 2 commits into from
Nov 29, 2019

Commits on Nov 29, 2019

  1. Fix remote wipe keychain storage (issue #1592) 

    The app password for the remote wipe was constantly being written in
WebFlowCredentials::slotFinished to the keychain, leading to unnecessary
write and log overhead on the system.

This fix introduces a check to only store the app password once in
a lifetime of the Account class. Also the method used to store the
password will be renamed from setAppPassword to writeAppPasswordOnce
to be more expressive.

Signed-off-by: Michael Schuster <michael@schuster.ms>
    @misch7
    misch7 committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    7da1972 View commit details
    Browse the repository at this point in the history

  2. Use ReadPasswordJob::finished for ReadPasswordJob 

    Signed-off-by: Michael Schuster <michael@schuster.ms>
    @misch7
    misch7 committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    c04a922 View commit details
    Browse the repository at this point in the history