Fix remote wipe keychain storage (issue #1592) #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The app password for the remote wipe was constantly being written in WebFlowCredentials::slotFinished to the keychain, leading to unnecessary write and log overhead on the system. This fix introduces a check to only store the app password once in a lifetime of the Account class. Also the method used to store the password will be renamed from setAppPassword to writeAppPasswordOnce to be more expressive. Signed-off-by: Michael Schuster <michael@schuster.ms>
Signed-off-by: Michael Schuster <michael@schuster.ms>
misch7
force-pushed
the
fix-remote-wipe-keychain
branch
from
a6c1a2e
to
c04a922
Compare
camilasan
approved these changes
Nov 29, 2019
|
/backport to stable-2.6 |
|
The backport to stable-2.6 failed. Please do this backport manually. |
|
✔️ 🍒 |
|
🍒 Cherry-picked to stable2.6 |
This was referenced Nov 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app password for the remote wipe was constantly being written in
WebFlowCredentials::slotFinishedto the keychain, leading to unnecessary write and log overhead on the system.This fix introduces a check to only store the app password once in a lifetime of the Account class. Also the method used to store the password will be renamed from
setAppPasswordtowriteAppPasswordOnceto be more expressive.Should solve these issues: