Fix and improve helm update script

[szaimen]

Addresses #1574 (comment) and below

Signed-off-by: Simon L szaimen@e.mail.de

[mrueg]

Thanks for the feedback @mrueg!

• Lowercase all variables

Thanks but since we automatically generate this with a bash script from a docker-compose file, I don't think it is worth the hassle which also might lead to unexpected problems.

• Drop the nextcloud-aio prefix in front of the file names (as it's already included in the chart name, this is uncommon)

Thanks but since we generate this via a bash script using kompose and I don't think it is worth it.

fwiw, this might be also worth a try: https://github.com/arttor/helmify

Thanks but what is the advantage over kompose? What would it change? Do you have an example with one of the files in this PR?

What I'm suggesting is: docker compose config -> kompose -> kubernetes yaml files -> helmify -> helm chart

See here for an example:
https://github.com/arttor/helmify/blob/main/test_data/sample-app.yaml
gets you: https://github.com/arttor/helmify/tree/main/examples/app

[szaimen]

What I'm suggesting is: docker compose config -> kompose -> kubernetes yaml files -> helmify -> helm chart

See here for an example: https://github.com/arttor/helmify/blob/main/test_data/sample-app.yaml gets you: https://github.com/arttor/helmify/tree/main/examples/app

Ah I see. However this looks a bit over-engineered to me as I am also not familiar with helmify. The current process is this:

docker compose -> kompose -> helm chart

All of this is done with a bash script that automates the process and edits things acordingly with sed which I find much easier than modifying things with helmify. :)

However I'd agree that patching the files with helmify would probably be more mature way of doing things - commits and pull requests are welcome!