Fix Provide Navigation List #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
jotoeri
requested review from
jancborchardt,
juliusknorr,
skjnldsv and
marcoambrosini
This was referenced Jun 9, 2020
jancborchardt
approved these changes
Jun 9, 2020
juliusknorr
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, seems like i need to fix my own PR #1107.
Just recognized, that to maintain compatibility to 'old' systems, that include the
ulon their own, the 100% height needs to be removed. Otherwise, the twoulconcur, resulting in two 50%ul-lists.Tested now the cases of manual ul, the new template ul and list-items without ul. They should all work now.