Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbar on AppNavigation #829

Closed
gary-kim opened this issue Jan 20, 2020 · 5 comments
Closed

Scrollbar on AppNavigation #829

gary-kim opened this issue Jan 20, 2020 · 5 comments
Labels
1. to develop Accepted and waiting to be taken care of feature: app-navigation Related to the app-navigation component

Comments

@gary-kim
Copy link
Contributor

gary-kim commented Jan 20, 2020

In the Calendar, opening or closing the settings introduces the scollbar for a second so the + New event and other buttons shrinks a bit for a split second.

output

Having overflow-y: hidden; would fix the issue but it looks like it is set to auto explicitly. Was that intentional? Maybe add the overflow-y as a configurable prop in case an app wants the scrollbar?

I can make the PR.

https://github.com/nextcloud/nextcloud-vue/blob/88c062728fb6b2df6977b45aa32e4e61b109c7e5/src/components/AppNavigation/AppNavigation.vue#L46

cc @skjnldsv @georgehrke

@gary-kim gary-kim added 1. to develop Accepted and waiting to be taken care of feature: app-navigation Related to the app-navigation component labels Jan 20, 2020
@korelstar korelstar reopened this Feb 20, 2020
@korelstar
Copy link
Contributor

Sorry, I fall over my keyboard. What I wanted to say: you can't know if your navigation is longer than available room. Hence overflow must be auto. The issue has to be solved using another fix.

@jotoeri
Copy link
Contributor

jotoeri commented May 30, 2020

@gary-kim Does removing the height: 100% on the ul fix your issue? Could be it doesn't need to re-render the 100% then...?

Edit: Just recognized i can check that on my own. 🤦‍♂ It doesn't solve.

@mejo-
Copy link
Contributor

mejo- commented Oct 27, 2023

Out of curiosity I just tried to reproduce the issue with the Calendar app on Nextcloud 27.1.3 (with Firefox 119 on Linux as browser). I wasn't able to reproduce this bug. Do others still face it?

@skjnldsv
Copy link
Contributor

Might be fixed with time and the various changes.
Also we're stepping away from the sliding settings for a modal 👍

@mejo-
Copy link
Contributor

mejo- commented Oct 28, 2023

Let's close the issue then. If anybody still faces the issue, don't hesitate to comment and/or reopen.

@mejo- mejo- closed this as completed Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of feature: app-navigation Related to the app-navigation component
Projects
None yet
Development

No branches or pull requests

5 participants