feat(adapters/surrealdb): update surrealdb.js to enable http connection strategy #8823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinschaer
requested review from
ubbe-xyz,
ndom91 and
balazsorban44
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@martinschaer is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
adapters
4 tasks
ThangHuuVu
reviewed
Oct 10, 2023
|
seems like fetch is missing for some reason - but it should be available in Node since v18 🤔 strange, will check more when I have time |
@ThangHuuVu turned out fetch is missing just on the global scope of jest. 88e2ab3 adds fetch to jest's globals |
balazsorban44
force-pushed
the
main
branch
3 times, most recently
from
fa96b45
to
65aa467
Compare
ThangHuuVu
approved these changes
Oct 26, 2023
|
thanks! merging, some other tests are failing but we will take another look later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
A bug was fixed on surrealdb.js 0.9.1 which enables the HTTP strategy: surrealdb/surrealdb.js#171
This PR includes unit tests for both strategies (RPC and HTTP) and docs.
🧢 Checklist
🎫 Affected issues
No open issues. Continuation of #6251