chore(test): add http strategy tests #8699
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@martinschaer is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
the
adapters
| import { runBasicTests } from "@auth/adapter-test" | ||
| import fetch from "node-fetch" |
There was a problem hiding this comment.
can we not use node-fetch here? tests were passing for me even without it.
There was a problem hiding this comment.
For this PR we need to wait for surrealdb.js to merge this other PR: surrealdb/surrealdb.js#171
I tested it using my fork with the fix
There was a problem hiding this comment.
| import fetch from "node-fetch" |
node-fetch (or any other fetch polyfill) indeed is not necessary anymore, as all Node.js versions have fetch already available.
balazsorban44
changed the title
|
Can we close this PR in favor of this one? #8823 Sorry for the mess... Also, looks like node 18.18.0 still requires node-fetch, so I kept it for now |
☕️ Reasoning
Surrealdb.js supports socket and HTTP connections. This PR includes unit tests for both types of connections.
🧢 Checklist
🎫 Affected issues
Please scout and link issues that might be solved by this PR.
Fixes: INSERT_ISSUE_LINK_HERE