Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade/rearrange dependencies #1093

Closed
wants to merge 3 commits into from

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Jan 12, 2021

What:
Upgrade dependencies to the newest version

use peerDependenciesMeta, instead of the non-standard optionalPeerDependencies.

move optional dependencies from dependencies

Why:
Keeping next-auth up-to-date, fixing bugs, reducing bundle size

Size change (click the image for the list of dependencies):
Before:
image

After:
image

How:
Ref to docs:

TODO: reference issues this would fix

Closes #1012
Closes #1097
Closes #1036
Closes #833

#1021 might also be related

@vercel
Copy link

vercel bot commented Jan 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/80ofl2g58
✅ Preview: https://next-auth-git-feature-upgrade-dependencies.nextauthjs.vercel.app

@vercel vercel bot temporarily deployed to Preview January 12, 2021 17:58 Inactive
@vercel vercel bot temporarily deployed to Preview January 12, 2021 17:59 Inactive
@balazsorban44 balazsorban44 added the wontfix This will not be worked on label Jan 19, 2021
@balazsorban44
Copy link
Member Author

As we are pushing to get a new stable release out, some of the changes in this PR has to wait until a further release. Because of this, I am going to close this for now.

@balazsorban44 balazsorban44 deleted the feature/upgrade-dependencies branch February 2, 2021 23:06
@greynguyen
Copy link

@balazsorban44 is this PR released? If not, do you know when it would be?

@balazsorban44
Copy link
Member Author

no, it's not, because it would probably be a breaking change. it is pushed back in our timeline for now and unfortunately I don't have an ETA. If you experience any problems related to this, please open an issue though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
2 participants