Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FaunaDB should be a dev dependency, not a regular one #1012

Closed
kripod opened this issue Dec 30, 2020 · 8 comments
Closed

FaunaDB should be a dev dependency, not a regular one #1012

kripod opened this issue Dec 30, 2020 · 8 comments
Labels
bug Something isn't working hacktoberfest-help-needed The maintainer needs help due to time constraint/missing knowledge

Comments

@kripod
Copy link
Contributor

kripod commented Dec 30, 2020

As I’ve noticed in the latest canary release (3.2.0-canary.3), faunadb has been added as a dependency, but it doesn’t seem to be used besides a test. I would like to suggest adding faunadb to devDependencies while removing it from dependencies.

@kripod kripod added the bug Something isn't working label Dec 30, 2020
@balazsorban44
Copy link
Member

We have something called peerOptionalDependencies, but honestly have no idea how we handle these, as it doesn't seem to be an npm standard. fauna should be added there I guess.

@kripod
Copy link
Contributor Author

kripod commented Dec 30, 2020

Yeah, I see your point, it should be implemented as outlined here, then: https://github.com/yarnpkg/rfcs/blob/master/accepted/0000-optional-peer-dependencies.md#2-detailed-design

@balazsorban44
Copy link
Member

I think we use this at the moment: https://github.com/christkv/require_optional

@kripod
Copy link
Contributor Author

kripod commented Dec 30, 2020

Unfortunately, that doesn’t seem to be a living standard. However, the peerDependenciesMeta field is respected by Yarn and will eventually be adopted by npm if my memories are correct.

@balazsorban44
Copy link
Member

cc @iaincollins

@balazsorban44 balazsorban44 added the hacktoberfest-help-needed The maintainer needs help due to time constraint/missing knowledge label Dec 30, 2020
@balazsorban44
Copy link
Member

https://docs.npmjs.com/cli/v7/configuring-npm/package-json#peerdependenciesmeta Looks like it is in npm@7 now!

@balazsorban44
Copy link
Member

Fauna has been removed for now, see the explanation at #1146

@balazsorban44
Copy link
Member

https://github.blog/2021-02-02-npm-7-is-now-generally-available/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest-help-needed The maintainer needs help due to time constraint/missing knowledge
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants