-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't require secret at build-time #10592
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10592 +/- ##
=======================================
Coverage 40.48% 40.48%
=======================================
Files 172 172
Lines 27754 27748 -6
Branches 1174 1168 -6
=======================================
- Hits 11235 11233 -2
+ Misses 16519 16515 -4 ☔ View full report in Codecov by Sentry. |
bf38de4
to
d75f74c
Compare
* fix: don't require secret at build-time * revert tests * update Dockerfile
* fix: don't require secret at build-time * revert tests * update Dockerfile
Follow-up on #10305
setEnvDefaults
might be invoked during build which started throwing an error in #10305.This reverts the early check and makes sure that the runtime check correctly catches an unavailable secret value, avoiding the cryptic message shown in #10305
Fixes #10538