test: Updated how we handle the koa-router nuance of wildcard routes #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrickard
approved these changes
Sep 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2588 +/- ##
==========================================
- Coverage 97.23% 97.18% -0.05%
==========================================
Files 291 291
Lines 45932 45932
==========================================
- Hits 44661 44639 -22
- Misses 1271 1293 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jsumners-nr
reviewed
Sep 19, 2024
Comment on lines
+17
to
+27
| function getPathToRegexpVersion() { | ||
| let pathToRegexVersion | ||
| try { | ||
| ;({ version: pathToRegexVersion } = JSON.parse( | ||
| fs.readFileSync(`${__dirname}/node_modules/path-to-regexp/package.json`) | ||
| )) | ||
| } catch { | ||
| pathToRegexVersion = '6.0.0' | ||
| } | ||
| return pathToRegexVersion | ||
| } |
There was a problem hiding this comment.
Absolutely ridiculous that this is necessary.
sumitsuthar
pushed a commit
to k2io/fork-node-newrelic
that referenced
this pull request
Sep 20, 2024
sumitsuthar
added a commit
to k2io/fork-node-newrelic
that referenced
this pull request
Sep 20, 2024
… routes (newrelic#2588)" This reverts commit 544c9e7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both
koa-rotuerand@koa/router13.0.1 usepath-to-regexp@8but@koa/routerreleased 13.1.0 and downgradedpath-to-regexp@6. This PR updates how we determined how to defined wildcard routes by keying off the version ofpath-to-regexpwhen present. If it is not present assume the legacy behavior.How to test
I suspect they remedy this version mismatch of
path-to-regexpbetween 13.0.1 and 13.1.0. I filed an issue here