Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removed noisy test log #2583

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

jsumners-nr
Copy link
Contributor

Refactors the test/unit/util/obfuscate-sql.test.js script to generate less noise.

@jsumners-nr jsumners-nr added the dev:tests Indicates only changes to tests label Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.18%. Comparing base (f44a99b) to head (fdf4750).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2583      +/-   ##
==========================================
- Coverage   97.22%   97.18%   -0.05%     
==========================================
  Files         291      291              
  Lines       45932    45932              
==========================================
- Hits        44659    44639      -20     
- Misses       1273     1293      +20     
Flag Coverage Δ
integration-tests-cjs-18.x 74.18% <ø> (ø)
integration-tests-cjs-20.x 74.19% <ø> (ø)
integration-tests-cjs-22.x 74.23% <ø> (ø)
integration-tests-esm-18.x 49.69% <ø> (ø)
integration-tests-esm-20.x 49.69% <ø> (ø)
integration-tests-esm-22.x 49.72% <ø> (ø)
unit-tests-18.x 88.88% <ø> (ø)
unit-tests-20.x 88.86% <ø> (-0.02%) ⬇️
unit-tests-22.x 88.89% <ø> (ø)
versioned-tests-18.x 78.98% <ø> (-0.16%) ⬇️
versioned-tests-20.x 78.96% <ø> (-0.18%) ⬇️
versioned-tests-22.x 78.97% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsumners-nr jsumners-nr marked this pull request as ready for review September 17, 2024 14:02
Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this one annoyed you before. Personally I don't see a diff, it's still "noisy" just in a diff way. But it's fine with me

@bizob2828 bizob2828 merged commit 3766ed6 into newrelic:main Sep 17, 2024
30 of 31 checks passed
@jsumners-nr jsumners-nr deleted the less-noise branch September 17, 2024 16:04
@jsumners-nr
Copy link
Contributor Author

I know this one annoyed you before. Personally I don't see a diff, it's still "noisy" just in a diff way. But it's fine with me

See https://github.com/newrelic/node-newrelic/pull/2582/files

image

sumitsuthar pushed a commit to k2io/fork-node-newrelic that referenced this pull request Sep 20, 2024
sumitsuthar added a commit to k2io/fork-node-newrelic that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only changes to tests
Projects
Status: Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

2 participants