feat: Added utilization info for ECS #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2565 +/- ##
=======================================
Coverage 97.22% 97.23%
=======================================
Files 290 291 +1
Lines 45882 45932 +50
=======================================
+ Hits 44608 44661 +53
+ Misses 1274 1271 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bizob2828
requested changes
Sep 12, 2024
| @@ -51,6 +56,7 @@ test('pricing system-info aws', function (t) { | |||
|
|
|||
| // This will throw an error if the sys info isn't being cached properly | |||
| t.ok(awsRedirect.isDone(), 'should exhaust nock endpoints') | |||
| t.ok(ecsScope.isDone()) | |||
There was a problem hiding this comment.
i know you have unit tests but this integration test should be assertion the ecs vendor:
t.same(systemInfo.vendors.ecs, {
ecsDockerId: 'ecs-container-1'
})
lib/utilization/docker-info.js
Outdated
| module.exports = { | ||
| clearVendorCache: clearDockerVendorCache, | ||
| getBootId, | ||
| getEcsContainerId, |
There was a problem hiding this comment.
Reading the spec, I think the new solution should be replacing the original
Merged
sumitsuthar
pushed a commit
to k2io/fork-node-newrelic
that referenced
this pull request
Sep 20, 2024
sumitsuthar
added a commit
to k2io/fork-node-newrelic
that referenced
this pull request
Sep 20, 2024
This reverts commit 2ad7c42.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2563.