fix: Nuget pack generates packagName.semver and not packageName-semver #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mrickard <maurice@mauricerickard.com>
svetlanabrennan
approved these changes
Sep 10, 2024
Merged
sumitsuthar
pushed a commit
to k2io/fork-node-newrelic
that referenced
this pull request
Sep 20, 2024
newrelic#2557) Signed-off-by: mrickard <maurice@mauricerickard.com>
sumitsuthar
added a commit
to k2io/fork-node-newrelic
that referenced
this pull request
Sep 20, 2024
…me-semver (newrelic#2557)" This reverts commit 32f55b7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Site extension publishing was tested on a fork; the filename structure there successfully used a
.before the semver value in the expected filename. The previous workflow specified a hyphen before the semver value, which does not match the file generated bynuget pack.How to Test
GHA workflows can only be run after merge to main, though arguably this could be tested in a fork.
This fix is a subtask of NR-300597