Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Convert metric and metrics-recorder tests to node:test #2552

Merged
merged 16 commits into from
Sep 11, 2024

Conversation

amychisholm03
Copy link
Contributor

@amychisholm03 amychisholm03 commented Sep 9, 2024

This PR resolves #2547.

Added assertMetrics and assertMetricValues to custom-assertions.

@amychisholm03 amychisholm03 marked this pull request as ready for review September 10, 2024 20:03
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.22%. Comparing base (abfb9f0) to head (63597be).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2552      +/-   ##
==========================================
+ Coverage   97.19%   97.22%   +0.02%     
==========================================
  Files         290      290              
  Lines       45478    45882     +404     
==========================================
+ Hits        44204    44608     +404     
  Misses       1274     1274              
Flag Coverage Δ
integration-tests-cjs-18.x 74.07% <ø> (+0.24%) ⬆️
integration-tests-cjs-20.x 74.08% <ø> (+0.24%) ⬆️
integration-tests-cjs-22.x 74.12% <ø> (+0.25%) ⬆️
integration-tests-esm-18.x 49.71% <ø> (+0.49%) ⬆️
integration-tests-esm-20.x 49.71% <ø> (+0.49%) ⬆️
integration-tests-esm-22.x 49.74% <ø> (+0.49%) ⬆️
unit-tests-18.x 88.86% <ø> (+0.10%) ⬆️
unit-tests-20.x 88.86% <ø> (+0.10%) ⬆️
unit-tests-22.x 88.87% <ø> (+0.10%) ⬆️
versioned-tests-18.x 79.08% <ø> (+0.07%) ⬆️
versioned-tests-20.x 79.08% <ø> (+0.07%) ⬆️
versioned-tests-22.x 79.09% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/lib/custom-assertions.js Outdated Show resolved Hide resolved
test/unit/metric/normalizer-tx-segment.test.js Outdated Show resolved Hide resolved
@bizob2828 bizob2828 added the dev:tests Indicates only changes to tests label Sep 11, 2024
@bizob2828 bizob2828 merged commit 7ae4af4 into newrelic:main Sep 11, 2024
29 checks passed
@amychisholm03 amychisholm03 deleted the metrics-tests branch September 11, 2024 17:44
@github-actions github-actions bot mentioned this pull request Sep 12, 2024
sumitsuthar pushed a commit to k2io/fork-node-newrelic that referenced this pull request Sep 20, 2024
sumitsuthar added a commit to k2io/fork-node-newrelic that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only changes to tests
Projects
Status: Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

Convert metric and metrics-recorder tests to node:test
3 participants