Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Convert config to node:test #2517

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Conversation

amychisholm03
Copy link
Contributor

No description provided.

@amychisholm03 amychisholm03 changed the title chore: Convert config to node:test chore: Convert config to node:test Aug 26, 2024
@amychisholm03 amychisholm03 linked an issue Aug 26, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.19%. Comparing base (9363eb0) to head (bc4fc73).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2517      +/-   ##
==========================================
+ Coverage   97.15%   97.19%   +0.03%     
==========================================
  Files         289      289              
  Lines       45415    45416       +1     
==========================================
+ Hits        44123    44140      +17     
+ Misses       1292     1276      -16     
Flag Coverage Δ
integration-tests-cjs-18.x 73.81% <ø> (+<0.01%) ⬆️
integration-tests-cjs-20.x 73.81% <ø> (-0.01%) ⬇️
integration-tests-cjs-22.x 73.85% <ø> (+<0.01%) ⬆️
integration-tests-esm-18.x 49.15% <ø> (+<0.01%) ⬆️
integration-tests-esm-20.x 49.15% <ø> (+<0.01%) ⬆️
integration-tests-esm-22.x 49.18% <ø> (+<0.01%) ⬆️
unit-tests-18.x 88.71% <ø> (+0.03%) ⬆️
unit-tests-20.x 88.71% <ø> (+0.03%) ⬆️
unit-tests-22.x 88.71% <ø> (+0.03%) ⬆️
versioned-tests-18.x 78.87% <ø> (-0.12%) ⬇️
versioned-tests-20.x 78.85% <ø> (-0.14%) ⬇️
versioned-tests-22.x 78.88% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amychisholm03 amychisholm03 marked this pull request as ready for review August 28, 2024 13:32
@amychisholm03 amychisholm03 requested review from jsumners-nr and bizob2828 and removed request for jsumners-nr August 28, 2024 14:09
test/unit/config/attribute-filter.test.js Outdated Show resolved Hide resolved
test/unit/config/config-formatters.test.js Outdated Show resolved Hide resolved
test/unit/config/config-location.test.js Outdated Show resolved Hide resolved
@bizob2828 bizob2828 merged commit 1534a73 into newrelic:main Aug 28, 2024
29 checks passed
@bizob2828 bizob2828 added the dev:tests Indicates only changes to tests label Aug 28, 2024
@amychisholm03 amychisholm03 deleted the config-tests branch August 28, 2024 19:27
@github-actions github-actions bot mentioned this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only changes to tests
Projects
Status: Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

Convert the config unit tests to node:test
3 participants