test: Removed server.start in grpc tests as it is deprecated and no longer needed #2372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed when adding support for Node 22 we had some deprecation warnings.
When adding
--trace-deprecation
to the entire integration run I discovered(node:99014) DeprecationWarning: Calling start() is no longer necessary. It can be safely omitted. at /Users/revans/code/pull-requests/node-newrelic/test/integration/grpc/reconnect.tap.js:221:16 at /Users/revans/code/pull-requests/node-newrelic/node_modules/@grpc/grpc-js/src/server.ts:869:11 at processTicksAndRejections (node:internal/process/task_queues:95:5)
It also existed in another grpc test.
How to Test
node test/integration/grpc/reconnect.tap.js
The deprecation warning is gone.
Additional Information
There is still this warning
But it is safe because if/when Node.js removes
punycode
theunicode-length
package will use its 3rd party dep of punycode based on this copy