test: Updated benchmark test results to output result files #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om run-bench, promisified the child-exit listener for JSON printing benchmark tests, temporarily bumped complexity threshold Signed-off-by: mrickard <maurice@mauricerickard.com>
…t tests Signed-off-by: mrickard <maurice@mauricerickard.com>
… counter Signed-off-by: mrickard <maurice@mauricerickard.com>
…hat is not wired up any longer
…e method as cb in the test data store
…run-bench to handle non-json returns Signed-off-by: mrickard <maurice@mauricerickard.com>
…ging of error, if a test is missing from one file. Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
jsumners-nr
reviewed
Jul 15, 2024
jsumners-nr
reviewed
Jul 15, 2024
bizob2828
requested changes
Jul 15, 2024
Signed-off-by: mrickard <maurice@mauricerickard.com>
…ark_results directory, removed extra NPM script Signed-off-by: mrickard <maurice@mauricerickard.com>
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated
run-bench.jsandbenchmark.jsto complete asynchronous tests before generating statisticsUpdated
run-bench.jsto allow JSON output to a file, and consolidate printing logicReduced cognitive complexity in
run-bench.jsHow to Test
npm run benchto run benchmark tests and output json result files tobenchmark_resultsGiven two benchJson outputs,
node bin/compare-bench-results.js {file1.json} {file2.json}will compare two benchmark runs, and write a markdown file tobenchmark_results.Related Issues
Closes NR-281645