fix: Updated redis v4 instrumentation to work with transactions(multi/exec) #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrickard
previously approved these changes
Jul 10, 2024
|
I have to tweak something. The client options are broken now. |
…sts for ensuring addCommand is associated to appropriate client
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In redis pre 4 we were able to instrument the underlying command executor which traced all running commands. In v4 we tried to instrument all commands attached to client. This did not work with transactions(multi + exec). This PR refators the instrumentation to wrap the redis commands queue
addCommandwhich is the equivalent of the pre v4 instrumentation.How to Test
Related Issues
Closes #2339