feat: Added support for account level governance of AI Monitoring #2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners-nr
force-pushed
the
issue-2325
branch
5 times, most recently
from
15e67a7
to
baa3798
Compare
bizob2828
requested changes
Jul 8, 2024
| * @param {string} params.type type of llm event(i.e.- LlmChatCompletionMessage, LlmTool, etc) | ||
| * @param {object} params.msg the llm event getting enqueued | ||
| * @param {string} params.pkgVersion version of langchain library instrumented | ||
| */ | ||
| common.recordEvent = function recordEvent({ agent, type, msg, pkgVersion }) { | ||
| common.recordEvent = function recordEvent({ agent, shim, type, msg, pkgVersion }) { | ||
| if (common.shouldSkipInstrumentation(agent.config) === true) { |
There was a problem hiding this comment.
this behavior is different than the other libraries so when ai_monitoring.enabled is false it still creates the events in memory but doesn't do anything with them.
There was a problem hiding this comment.
there are cases where it is creating LLM events like LlmErrorMessage. It's also doing a lot of parsing. I would change langchain instrumentation and check for this flag before it attempts to event create any llm events
bizob2828
requested changes
Jul 9, 2024
bizob2828
previously approved these changes
Jul 9, 2024
|
I'm going to wait to merge this until the team is ready to ship the feature |
bizob2828
approved these changes
Jul 9, 2024
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2325.