feat: Added AIM support for Meta Llama3 models in AWS Bedrock #2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amychisholm03
commented
Jun 26, 2024
amychisholm03
commented
- Will now just check if the model name starts with meta-llama, not meta-llama2
- Modified unit and versioned:major tests to test both llama2 and llama3, or just llama if applicable
jsumners-nr
previously approved these changes
Jun 27, 2024
bizob2828
changed the title
bizob2828
requested changes
Jun 27, 2024
There was a problem hiding this comment.
A few suggestions to reduce the amount of test code we'd have to maintain. the llama2/3 mocks are identical and prob unnecessary. you could consolidate it and update the versioned tests. I also plan to reach out and discuss some git commit tips as this branch has a lot of superfluous commits in it
| @@ -119,6 +119,12 @@ function handler(req, res) { | |||
| break | |||
| } | |||
|
|
|||
| case 'meta.llama3-8b-instruct-v1:0': | |||
| case 'meta.llama3-70b-instruct-v1:0': { | |||
| response = responses.llama3.get(payload.prompt) | |||
There was a problem hiding this comment.
since llama3 responses are identical you don't really need mocks. you could just return the llama2 data
jsumners-nr
approved these changes
Jun 27, 2024
jsumners-nr
requested changes
Jun 27, 2024
There was a problem hiding this comment.
Please update https://github.com/newrelic/node-newrelic/blob/main/ai-support.json
https://github.com/newrelic/node-newrelic/blob/main/ai-support.spec.md should explain everything, but please ask me if you have questions.
This was referenced Jun 28, 2024
This was referenced Jul 20, 2024
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.