Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updated mysql tests to use MySQL 8.3 #2280

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

jsumners-nr
Copy link
Contributor

Comment on lines +41 to +42
await runCommand(client, `FLUSH PRIVILEGES`)
await runCommand(client, `FLUSH TABLES`)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we really need these, but they certainly don't hurt.

@jsumners-nr jsumners-nr marked this pull request as ready for review June 17, 2024 13:41
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (7e3cab9) to head (9ce916f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2280      +/-   ##
==========================================
- Coverage   96.27%   96.27%   -0.01%     
==========================================
  Files         284      284              
  Lines       45230    45230              
==========================================
- Hits        43544    43543       -1     
- Misses       1686     1687       +1     
Flag Coverage Δ
unit-tests-16.x 89.18% <ø> (ø)
unit-tests-18.x 89.16% <ø> (ø)
unit-tests-20.x 89.16% <ø> (ø)
versioned-tests-16.x 77.57% <ø> (-0.08%) ⬇️
versioned-tests-18.x 78.58% <ø> (-0.08%) ⬇️
versioned-tests-20.x 78.59% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrickard mrickard self-assigned this Jun 17, 2024
@jsumners-nr jsumners-nr merged commit 11e0f8c into newrelic:main Jun 17, 2024
31 checks passed
@jsumners-nr jsumners-nr deleted the issue-2269 branch June 17, 2024 14:20
@jsumners-nr jsumners-nr added the dev:automation Indicates CI automation label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:automation Indicates CI automation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Drop support for mysql 5.7
2 participants