Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updated GitHub Actions versions #2272

Merged
merged 3 commits into from
Jun 12, 2024
Merged

chore: Updated GitHub Actions versions #2272

merged 3 commits into from
Jun 12, 2024

Conversation

jsumners-nr
Copy link
Contributor

@jsumners-nr jsumners-nr commented Jun 12, 2024

This PR updates all of the versions of the various actions we utilize.

  1. It solves warnings like:
    image
  2. It limits our usage of third party actions to specific commits. This is a guard against a potential attack where the action's floating vX tag could be re-pointed to a malicious commit. The only third party actions we "trust" are the actions under the actions/ namespace (i.e. the ones maintained by GitHub directly).
  3. There should not be any noticeable change in the outcome of the actions. The deprecation of version of Node used by actions does not affect the version of Node used by jobs.
  4. GitHub is already forcing the change behind the scenes https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

A successful run of the main CI workflow with this changes can be seen at https://github.com/newrelic/node-newrelic/actions/runs/9487225943

@jsumners-nr jsumners-nr added the dev:automation Indicates CI automation label Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.26%. Comparing base (6c964b2) to head (c1cffc7).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2272      +/-   ##
==========================================
- Coverage   96.32%   96.26%   -0.06%     
==========================================
  Files         284      284              
  Lines       45178    45178              
==========================================
- Hits        43518    43491      -27     
- Misses       1660     1687      +27     
Flag Coverage Δ
integration-tests-16.x ?
integration-tests-18.x ?
integration-tests-20.x ?
unit-tests-16.x 89.17% <ø> (ø)
unit-tests-18.x 89.16% <ø> (ø)
unit-tests-20.x 89.16% <ø> (ø)
versioned-tests-16.x 77.57% <ø> (-0.06%) ⬇️
versioned-tests-18.x 78.56% <ø> (-0.08%) ⬇️
versioned-tests-20.x 78.57% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsumners-nr jsumners-nr marked this pull request as ready for review June 12, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:automation Indicates CI automation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants