ci: Updated security agent workflow to use large runners when available #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners-nr
approved these changes
Jun 12, 2024
| @@ -82,6 +82,7 @@ jobs: | |||
| run: TEST_CHILD_TIMEOUT=600000 npm run versioned:security | |||
| env: | |||
| VERSIONED_MODE: --${{ inputs.mode || 'major' }} | |||
| JOBS: 4 # 2 per CPU seems to be the sweet spot in GHA (July 2022) | |||
| # Run more jobs when using larger runner, otherwise 2 per CPU seems to be the sweet spot in GHA default runners(July 2022) | |||
| JOBS: ${{ vars.NR_RUNNER && 16 || 4 }} | |||
There was a problem hiding this comment.
I'm surprised the GHA parser is this robust.
|
Ran with larger runner and 4 jobs and it passed here. Waiting on the 16 jobs run |
This was referenced Jul 20, 2024
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues from #2270