Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Updated langchain versioned tests to separate the vectorstore and other tests. This is to avoid peer resolution of @langchain/community package that is being used to test the elasticsearch vectorstore #2216

Merged
merged 1 commit into from
May 28, 2024

Conversation

bizob2828
Copy link
Member

@bizob2828 bizob2828 commented May 28, 2024

Description

We have issues when running langchain tests when the version of @langchain/core differs from @langchain/community@0.2.3.

/home/runner/work/node-newrelic/node-newrelic/test/versioned/langchain/tools.tap.js @langchain/core@0.2.2 @langchain/openai@0.0.34 @langchain/community@0.2.3 @elastic/elasticsearch@8.13.1
stdout

---------------------------------------------------------------
stderr
npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: langchain-tests@0.0.0
npm error Found: @google-ai/generativelanguage@0.2.1
npm error node_modules/@google-ai/generativelanguage
npm error   peerOptional @google-ai/generativelanguage@"^0.2.1" from langchain@0.1.37
npm error   node_modules/langchain
npm error     peerOptional langchain@"~0.1.19" from @getzep/zep-cloud@1.0.3
npm error     node_modules/@getzep/zep-cloud
npm error       peerOptional @getzep/zep-cloud@"~1.0.0" from @langchain/community@0.2.3
npm error       node_modules/@langchain/community
npm error         @langchain/community@"0.2.3" from the root project
npm error
npm error Could not resolve dependency:
npm error peerOptional @google-ai/generativelanguage@"^2.5.0" from @langchain/community@0.2.3
npm error node_modules/@langchain/community
npm error   @langchain/community@"0.2.3" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /home/runner/.npm/_logs/2024-05-28T16_50_37_812Z-eresolve-report.txt

npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2024-05-28T16_50_37_812Z-debug-0.log
Failed to execute npm install --no-save --no-package-lock --no-audit --no-fund @langchain/core@0.2.2 @langchain/openai@0.0.34 @langchain/community@0.2.3 @elastic/elasticsearch@8.13.1

===============================================================
Versions executed

I worked around this by pinning a version of @langchain/community, elasticsearch in a separate test stanza. The library under test is @langchain/core so it'll be ok to pin the other versions until @langchain/core breaks with the pinned versions, which may or may happen in the future

How to Test

npm run versioned:internal langchain

…nd other tests. This is to avoid peer resolution of `@langchain/community` package that is being used to test the elasticsearch vectorstore
@bizob2828 bizob2828 added the dev:tests Indicates only changes to tests label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only changes to tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants