chore: Made pre-commit hook require dependency changes #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizob2828
requested changes
Apr 29, 2024
| break | ||
| fi | ||
| done | ||
|
|
||
| if [ -n "$RUN_THIRD_PARTY" ]; then | ||
| if [ ${PKG_HAS_CHANGED} -eq 0 ]; then | ||
| exit 0 |
There was a problem hiding this comment.
can we add an echo here so we now it's a no-op. same for at the end when it doesn't updating third party deps?
bizob2828
approved these changes
Apr 29, 2024
This was referenced Apr 29, 2024
bizob2828
pushed a commit
that referenced
this pull request
May 20, 2024
This was referenced Jul 20, 2024
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it annoying that the pre-commit hook updates the third party notices when any change to the
package.jsonfile has been made. This PR updates the hook to only update the third party notices when there has been a change to the various dependencies.