Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip Elasticsearch tests on Node 20 #1797

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

bizob2828
Copy link
Member

For some reason the versioned tests for elasticsearch are timing out but only run on main. They work just fine in branches. I spent a lot of time trying to track it down and do not want to block the main line any longer. I plan on continuing triage but will do so async.

@mrickard mrickard self-assigned this Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #1797 (90f8448) into main (9ca78ae) will decrease coverage by 0.06%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1797      +/-   ##
==========================================
- Coverage   96.84%   96.78%   -0.06%     
==========================================
  Files         198      199       +1     
  Lines       38755    38901     +146     
==========================================
+ Hits        37531    37652     +121     
- Misses       1224     1249      +25     
Flag Coverage Δ
integration-tests-16.x 78.86% <100.00%> (+0.01%) ⬆️
integration-tests-18.x 79.12% <100.00%> (+<0.01%) ⬆️
integration-tests-20.x 79.13% <100.00%> (+<0.01%) ⬆️
unit-tests-16.x 91.38% <85.61%> (-0.03%) ⬇️
unit-tests-18.x 91.36% <85.61%> (-0.03%) ⬇️
unit-tests-20.x 91.36% <85.61%> (-0.03%) ⬇️
versioned-tests-16.x 73.03% <93.83%> (-2.59%) ⬇️
versioned-tests-18.x 73.03% <93.83%> (-2.59%) ⬇️
versioned-tests-20.x 72.94% <100.00%> (-2.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/instrumentation/@elastic/elasticsearch.js 100.00% <100.00%> (ø)
lib/instrumentations.js 100.00% <100.00%> (ø)
lib/shim/datastore-shim.js 99.41% <100.00%> (+<0.01%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bizob2828 bizob2828 merged commit c454a7e into main Oct 5, 2023
49 of 50 checks passed
@bizob2828 bizob2828 deleted the skip-es-node-20 branch October 5, 2023 17:40
@github-actions github-actions bot mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants