Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added separate instrumentation for redis.asyncio.client #806

Closed
wants to merge 4 commits into from
Closed

Added separate instrumentation for redis.asyncio.client #806

wants to merge 4 commits into from

Conversation

ahmedhr
Copy link
Contributor

@ahmedhr ahmedhr commented May 1, 2023

Overview

This PR will add a new instrumentation for redis.asyncio.client and remove aioredis' intrumentation dependency

@ahmedhr ahmedhr requested a review from a team as a code owner May 1, 2023 21:41
@CLAassistant
Copy link

CLAassistant commented May 1, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ ahmedhr
✅ lrafeei
❌ mergify[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@ahmedhr ahmedhr mentioned this pull request May 1, 2023
@ahmedhr ahmedhr marked this pull request as draft May 1, 2023 21:55
@ahmedhr ahmedhr marked this pull request as ready for review May 2, 2023 07:47
lrafeei and others added 4 commits May 2, 2023 13:53
* Change import format

* Initial commit

* Add more tests to adapter_waitress

* Remove commented out code

* [Mega-Linter] Apply linters fixes

* Add assertions to all tests

* Add more NR testing to waitress

---------

Co-authored-by: lrafeei <lrafeei@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Added separate instrumentation for redis.asyncio.client

Added separate instrumentation for redis.asyncio.client
Added separate instrumentation for redis.asyncio.client
@ahmedhr ahmedhr closed this May 2, 2023
@ahmedhr ahmedhr deleted the fix-instrumentation-redis-asyncio branch May 2, 2023 10:38
@ahmedhr
Copy link
Contributor Author

ahmedhr commented Jul 9, 2023

Reopening the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants