graphql-java 17.0+ instrumentation #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twcrone
reviewed
Oct 15, 2021
| } | ||
|
|
||
| verifyInstrumentation { | ||
| passes 'com.graphql-java:graphql-java:[17.0,17.3]' |
There was a problem hiding this comment.
Should we make this open ended to any 17.x? GraphQL Java 17 is LTS right?
twcrone
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This instruments graphql-java 17.0+
This a 99% copy paste of the 16.2 instrumentation module. 16.2 fails on 17.0+ because there was a change to a method return type.
The updates in this PR:
handleFetchingExceptionis updated.Ran the verifier locally and tested with a dgs example app running graphql-java 17.3.
AIT looks good - https://javaagent-build.pdx.vm.datanerd.us/job/AIT_Configurable/157/
I ran those 3 failures locally and they all pass.