Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weaver jax rs issue #234

Merged
merged 5 commits into from
Mar 4, 2021
Merged

Fix weaver jax rs issue #234

merged 5 commits into from
Mar 4, 2021

Conversation

jasonjkeller
Copy link
Contributor

@jasonjkeller jasonjkeller commented Mar 4, 2021

  • Refactors WeavePackage to process annotation based instrumentation classes properly when multiple classes with the same annotations exist
  • Adds tests

This fixes jax-rs based transactions that were previously being named incorrectly when using sub-resources:

Screen Shot 2021-03-03 at 3 21 41 PM

Resolves #233

Copy link
Contributor

@XiXiaPdx XiXiaPdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍣 Awesome work, looks great!

@jasonjkeller
Copy link
Contributor Author

AITs are green after latest changes: https://javaagent-build.pdx.vm.datanerd.us/view/All/job/JavaAgent_PR_AIT/51/

@jasonjkeller jasonjkeller merged commit 6f27b7e into main Mar 4, 2021
@jasonjkeller jasonjkeller deleted the fix-weaver-jax-rs-issue branch March 4, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants