Make sure we clean up the dtTracer and externalTracer when we get an … #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exception to prevent memory leaks. Also caught a couple edge cases for missed UnknownHost exceptions
jtduffy
approved these changes
May 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1902 +/- ##
============================================
- Coverage 70.67% 70.67% -0.01%
+ Complexity 9861 9860 -1
============================================
Files 826 826
Lines 39804 39804
Branches 6062 6062
============================================
- Hits 28131 28130 -1
Misses 8950 8950
- Partials 2723 2724 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…exception to prevent memory leaks. Also caught a couple edge cases for missed UnknownHost exceptions