Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws bedrock llm support #1837

Merged
merged 76 commits into from
Apr 17, 2024
Merged

Aws bedrock llm support #1837

merged 76 commits into from
Apr 17, 2024

Conversation

jasonjkeller
Copy link
Contributor

@jasonjkeller jasonjkeller commented Apr 2, 2024

This PR achieves code completion for the Java Agent - AIM Support (Bedrock) milestone.

It adds:

  • Instrumentation for AWS Bedrock and supported LLM models
  • Adds new API: void recordLlmFeedbackEvent(Map<String, Object> llmFeedbackEventAttributes)
  • Adds new API: void setLlmTokenCountCallback(LlmTokenCountCallback llmTokenCountCallback)

It adheres to the following agent specs:

deleonenriqueta and others added 24 commits March 27, 2024 16:43
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 52.58621% with 55 lines in your changes are missing coverage. Please review.

Project coverage is 69.98%. Comparing base (4060a06) to head (70736f0).
Report is 1 commits behind head on main.

Files Patch % Lines
...c/agent/bridge/aimonitoring/AiMonitoringUtils.java 0.00% 22 Missing ⚠️
...c/agent/attributes/LlmEventAttributeValidator.java 0.00% 11 Missing ⚠️
...c/agent/service/analytics/InsightsServiceImpl.java 26.66% 10 Missing and 1 partial ⚠️
...idge/aimonitoring/LlmTokenCountCallbackHolder.java 0.00% 5 Missing ⚠️
...m/newrelic/agent/model/LlmCustomInsightsEvent.java 0.00% 2 Missing ⚠️
...in/java/com/newrelic/agent/TransactionApiImpl.java 0.00% 2 Missing ⚠️
...nt/src/main/java/com/newrelic/agent/AgentImpl.java 0.00% 1 Missing ⚠️
...com/newrelic/opentelemetry/OpenTelemetryAgent.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1837      +/-   ##
============================================
- Coverage     70.86%   69.98%   -0.88%     
+ Complexity     9973     9892      -81     
============================================
  Files           829      835       +6     
  Lines         39984    40096     +112     
  Branches       6058     6068      +10     
============================================
- Hits          28333    28061     -272     
- Misses         8924     9350     +426     
+ Partials       2727     2685      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jtduffy jtduffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, especially like the READMEs with examples

@jasonjkeller jasonjkeller self-assigned this Apr 17, 2024
@jasonjkeller jasonjkeller merged commit 85ed9d6 into main Apr 17, 2024
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants