Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction GUID to ErrorEvent instances #1813

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Add transaction GUID to ErrorEvent instances #1813

merged 1 commit into from
Mar 25, 2024

Conversation

jtduffy
Copy link
Contributor

@jtduffy jtduffy commented Mar 22, 2024

Errors inbox team validated that both the ErrorEvent and TracedError payloads contain the transaction GUID in the proper spots when DT is disabled.

@jtduffy jtduffy requested a review from a team March 22, 2024 19:18
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.89%. Comparing base (9aee916) to head (f5b25de).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1813   +/-   ##
=========================================
  Coverage     70.89%   70.89%           
- Complexity     9956     9965    +9     
=========================================
  Files           827      828    +1     
  Lines         39880    39957   +77     
  Branches       6043     6053   +10     
=========================================
+ Hits          28272    28327   +55     
- Misses         8887     8899   +12     
- Partials       2721     2731   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtduffy
Copy link
Contributor Author

jtduffy commented Mar 25, 2024

Pekko failure due to changes not being merged to agent main yet.

@jtduffy jtduffy merged commit a977065 into main Mar 25, 2024
106 of 107 checks passed
@jtduffy jtduffy deleted the error-guid branch March 25, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants