Instrument the Kafka bootstrap nodes #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kford-newrelic
added
the
on-roadmap
kford-newrelic
removed
the
on-roadmap
|
@fryckbos we had to move our review of this out to the Apr-Jun quarter |
meiao
reviewed
Feb 14, 2023
| } | ||
|
|
||
| public NewRelicMetricsReporter(List<String> nodes) { | ||
| this.nodes = nodes; |
There was a problem hiding this comment.
To prevent the concatenation of Strings every harvest, the metric name for the nodes could be calculated here.
There was a problem hiding this comment.
I moved the creation of the metric names to init, does that make sense to you?
kford-newrelic
added
the
on-roadmap
meiao
approved these changes
Feb 28, 2023
|
Tests passed on #1165 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a new metric that captures the Kafka bootstrap nodes.
Testing
The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,
Checks
[x] Are your contributions backwards compatible with relevant frameworks and APIs? Yes
[x] Does your code contain any breaking changes? No
[x] Does your code introduce any new dependencies? No