JdbcHelper urlTofactory Map replacement #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephan202
reviewed
Jan 3, 2023
...t-bridge-datastore/src/main/java/com/newrelic/agent/bridge/datastore/ExpiringValueCache.java
Show resolved
Hide resolved
meiao
reviewed
Feb 14, 2023
|
|
||
| private final V wrappedValue; | ||
|
|
||
| private final Instant timeCreated; |
There was a problem hiding this comment.
can these be longs?
it would save some allocation from the heap.
| ExpiringValueLogicFunction expireLogicFunction) { | ||
| wrappedMap = new ConcurrentHashMap<>(); | ||
|
|
||
| TimerTask task = new TimerTask() { |
There was a problem hiding this comment.
Could we use a static ScheduledThreadPoolExecutor?
Or else we'd be creating and holding one Thread per cache.
|
@meiao Comments addressed:
|
tbradellis
approved these changes
Feb 17, 2023
|
It is not trivial to use Caffeine in this module due to the way it is loaded to the JVM. |
toddwest
pushed a commit
to toddwest/newrelic-java-agent
that referenced
this pull request
Feb 17, 2023
* WIP * Refactoring of cache class; more tests * Address PR comments: Instant --> long; static executor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the existing ConcurrentHashMap used for the
urlToFactoryandurlToDatabaseNamemaps with a simple, custom cache that can expire items in the cache based on the last time an item was accessed.The ConcurrentHashMap implementations were causing issues when used with MySql replication, where URLs to target replica databases were comprised of unique, generated Strings, causing the maps to grow without bound, which could eventually cause an OOM exception.