Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks that there is a transaction prior to adding CLM attrs #1051

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

meiao
Copy link
Contributor

@meiao meiao commented Oct 21, 2022

Overview

When adding CLM attrs to an span, going thru the add attribute code, it tries to get a transaction.
But if the @trace is someplace where there is no transaction, this causes an NPE.

This PR adds a guard to prevent that from happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An error occurred saving the clm attributes: java.lang.NullPointerException
3 participants