Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for using Sitecore.Logging and log4net together #2537

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

chynesNR
Copy link
Member

A customer attempted to use Sitecore.Logging and log4net in the same application. Sitecore.Logging uses an old fork of log4net that has different properties, and the instrumentation was not built to handle both at once. The wrapper would throw errors and eventually be disabled. Now they will work side by side.

This also adds the ability to run integration tests on multiple loggers at once, in case we run into other similar logging conflicts in the future.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.50%. Comparing base (227003a) to head (f60d898).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2537      +/-   ##
==========================================
+ Coverage   80.47%   80.50%   +0.02%     
==========================================
  Files         459      459              
  Lines       28775    28873      +98     
  Branches     3153     3167      +14     
==========================================
+ Hits        23158    23244      +86     
- Misses       4837     4843       +6     
- Partials      780      786       +6     
Flag Coverage Δ
Agent 81.49% <ø> (+0.02%) ⬆️
Profiler 71.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@chynesNR chynesNR merged commit 332529b into main Jun 11, 2024
93 checks passed
@chynesNR chynesNR deleted the feat/use-multiple-loggers branch June 11, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants