Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows service integration draft #16601

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

bradleycamacho
Copy link
Contributor

NR-217446

Copy link

Hi @bradleycamacho 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). If you add any more commits, you can comment netlify build on this PR to update the preview.

Copy link

github-actions bot commented Mar 20, 2024

Deploy Preview failed!

Name Link
🔨 Latest commit c06331b
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/65fb11dbacdb890008c2f184

Copy link
Contributor

@nbaenam nbaenam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bradleycamacho, I added some suggestions.

src/install/windows-service/intro.mdx Outdated Show resolved Hide resolved
src/install/windows-service/install-infra.mdx Outdated Show resolved Hide resolved

To use the Apache Flink integration, you need to also [install the infrastructure agent](/docs/infrastructure/install-infrastructure-agent/get-started/install-infrastructure-agent-new-relic/) on the same host. The infrastructure agent monitors the host itself, while the integration you'll install in the next step extends your monitoring with specific data such as database and instance metrics.

You must have <DoNotTranslate>**version 1.12.1 or higher**</DoNotTranslate> for our [infrastructure monitoring agent](/docs/infrastructure/install-infrastructure-agent/windows-installation/install-infrastructure-monitoring-agent-windows) installed on a supported host. The x86 Windows versions are not yet supported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last sentence is passive.

src/install/windows-service/install-integration.mdx Outdated Show resolved Hide resolved
src/install/windows-service/configure-integration.mdx Outdated Show resolved Hide resolved
* Uncomment `exporter_bind_address:` and `exporter_bind_port:`
* Add the name of the services you want to monitor to `include_matching_entities:`

By default, no service is included. To include and filter services, you must edit `include_matching_entities:`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no service is included is passive.


By default, no service is included. To include and filter services, you must edit `include_matching_entities:`.

Also, the configuration option [`inventory_source`](/docs/infrastructure/host-integrations/infrastructure-integrations-sdk/specifications/host-integrations-standard-configuration-format) is not compatible with the integration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/install/windows-service/whatsNext.mdx Outdated Show resolved Hide resolved
Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/660af47ee4397f994368158c
😎 Deploy Preview https://deploy-preview-16601--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bradleycamacho bradleycamacho marked this pull request as ready for review April 2, 2024 14:59
@bradleycamacho bradleycamacho merged commit 04a16ee into develop Apr 2, 2024
14 of 18 checks passed
@bradleycamacho bradleycamacho deleted the draft-windows-service branch April 2, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants